Proposal to update all IDs to Long

[iroussos]

Hi, I am a member of the Database Group at GitLab.

I am creating this issue in response to a few other issues I can see already created (#805, #809)

It seems that there are GitLab projects with more than 2.15 Billion builds, which means that you have to switch to using a Long integer for those IDs.

In general, most IDs in GitLab are using 8-byte integers, with a few old tables (pre rails 5.1) that were using 4-byte integers for their PKs. Those are also being transitioned to use 8-byte integers, so you can safely assume that in the long run all the IDs will be 8-byte integers. (You can find more details in a recent epic where we documented our efforts to address the tables at most risk to overflow)

If you agree, I would propose that you switch all the IDs in gitlab4j to Long from Integer. Thank you!

[jabby]

@iroussos I will update all the IDS to Long next week.

[iroussos]

Thank you @jabby!

[jabby]

I'm not sure which version number I should use for this. Actually, gitlab4j-api does not follow semver but this is a kind of bigbang. Should I use 5.x version for this ? If so, should I also clean some of the API like finally removing V3 support?

@iroussos do you have a suggestion?

[iroussos]

Thank you @jabby for the ping,

I am not a contributor to gitlab4j-api, so I have no opinion on the versioning approach that should be followed.

API V3 is no longer supported, so it would be great if you could remove it. If semver was followed, normally that would result to a major version bump, but that's a feature already broken for this library, so it's for the active developer community of this project to decide.