-
Notifications
You must be signed in to change notification settings - Fork 486
Closed
Description
Both endpoints:
POST /projects/:id/repository/files/:file_pathPUT /projects/:id/repository/files/:file_pathAre returning a response:
{
"file_path": "app/project.rb",
"branch": "master"
}But this client library is mapping the response to a org.gitlab4j.api.models.RepositoryFile where all the fields are set to null except file.getFilePath():
| public RepositoryFile createFile(Object projectIdOrPath, RepositoryFile file, String branchName, String commitMessage) throws GitLabApiException { |
| public RepositoryFile updateFile(Object projectIdOrPath, RepositoryFile file, String branchName, String commitMessage) throws GitLabApiException { |
I think this result type is quite misleading. (for example you do not expect file.getCommitId() to be null)
I can understand that changing this would be a breaking change.
Maybe one thing that can be considered is to put the branch attribute value in file.getRef()
Metadata
Metadata
Assignees
Labels
No labels