Skip to content

Conversation

@NadeoWolf
Copy link
Contributor

Added the missing TopicsAPI.
Due to compatibility problems with Maven, I have only been able to test the new functions manually.

…compatibility.

Added 'topic', 'topic_id' and 'imported'(Missing) to ProjectFilter instead.
Copy link
Collaborator

@jmini jmini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think some unit tests should be extended (I can have a look).

Thank you very much for this contribution!

Copy link
Collaborator

@jmini jmini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good now. Also the maven build is green.

I think it would be good to perform manual tests against a real GitLab instance.

Copy link
Collaborator

@jmini jmini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is some work to do (see comments)

@NadeoWolf
Copy link
Contributor Author

Im on Holiday. Will check it after 4. September.

@jmini
Copy link
Collaborator

jmini commented Aug 21, 2023

Will check it after 4. September.

No problem.
I had some fixes locally. I pushed them to your branch.

Copy link
Collaborator

@jmini jmini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. 👍

I would like to perform some manual tests before I merge.

Thank you for this contribution 🎉

jmini added a commit to jmini/gitlab-experiments that referenced this pull request Sep 19, 2023
@jmini jmini merged commit 69c7096 into gitlab4j:main Sep 19, 2023
@trp-samer-adra
Copy link

Any idea when this is getting released? Hoping to use it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants