Skip to content

Conversation

@istsergey
Copy link
Contributor

Double-Checked Locking without volatile field can work incorrectly
http://www.cs.umd.edu/~pugh/java/memoryModel/DoubleCheckedLocking.html

@gmessner
Copy link
Collaborator

gmessner commented Feb 6, 2018

@istsergey
While it may not harm marking these volatile, it is not needed as all the sub-API objects hold no state (they are immutable). To make them truly immutable, just need to mark the single field in AbstractApi final, as follows:

private final  GitLabApi gitLabApi;

@istsergey
Copy link
Contributor Author

@gmessner you are right. Please reject my pull request.

@gmessner
Copy link
Collaborator

gmessner commented Feb 8, 2018

Closed per submitter's request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants