Skip to content

Conversation

@fcaylus
Copy link
Contributor

@fcaylus fcaylus commented Aug 26, 2019

This only works for admin users

Solve #427

Signed-off-by: Fabien Caylus fabien.caylus@gmail.com

This only works for admin users

Signed-off-by: Fabien Caylus <fabien.caylus@gmail.com>
@fcaylus fcaylus force-pushed the feature/get-user-by-extern-uid branch from 0be997a to fc99cc4 Compare August 26, 2019 15:14
# this if you'd like to test against a different project
TEST_EXTERNAL_PROVIDER=github
TEST_EXTERNAL_UID=2435223452345

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Tranqyll SInce this is dummy data, what would the reason to change it be? Also, we don't change/override any settings in this file, they are done in ~/test-gitlab4j.properties

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the tests, I need to register a Gitlab Identity (https://github.com/gitlab4j/gitlab4j-api/pull/428/files/fc99cc4a809c8e701e7465171cc7a7e453e726b4#diff-179c0c9282e28646cdd416dd74590443R168). I thought test-gitlab4j.properties was an example of all possible properties and needed to be updated.

What should I do, remove it ?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Tranqyll
It remains here but commented out, and then you create a ~/test-gitlab4j.properties file and put it in there for testing.

@gmessner
Copy link
Collaborator

@Tranqyll First off, thank you for the contribution. Just one small question in the commits.

@gmessner
Copy link
Collaborator

@Tranqyll
It will be more difficult to explain all the changes that need to be made rather than make them myself. But in short, testing this should be optional and should not make mods to the IntegrationTestSuite setup. A user should be created in the TestUserApi class to test this and only if the values are specified in ~/test-gitlab4j.properties

Later today when I have time I will merge this and then make the appropriate changes. I'll let you know when that is complete.

@gmessner gmessner merged commit 4ed3fe9 into gitlab4j:master Sep 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants