Skip to content

Updating System Hook tests with commentary #727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 10, 2021
Merged

Updating System Hook tests with commentary #727

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
52 changes: 34 additions & 18 deletions src/test/java/org/gitlab4j/api/TestSystemHooksApi.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,15 +59,23 @@ public void beforeMethod() {
public void testAddSystemHook() throws GitLabApiException {

SystemHook hook = gitLabApi.getSystemHooksApi().addSystemHook(TEST_HOOK_URL, TEST_SECRET_TOKEN, true, false, true);
assertNotNull(hook);
assertEquals(TEST_HOOK_URL, hook.getUrl());
assertTrue(hook.getPushEvents());
assertFalse(hook.getTagPushEvents());
assertFalse(hook.getMergeRequestsEvents());
assertTrue(hook.getRepositoryUpdateEvents());
assertTrue(hook.getEnableSslVerification());

gitLabApi.getSystemHooksApi().deleteSystemHook(hook);
try {
assertNotNull(hook);
assertEquals(TEST_HOOK_URL, hook.getUrl());
assertTrue(hook.getPushEvents());
assertFalse(hook.getTagPushEvents());
assertFalse(hook.getMergeRequestsEvents());

// TODO: Attribute "repository_update_events" is not being honored by GitLab API as per issue
// https://gitlab.com/gitlab-org/gitlab/-/issues/335129
// Revisit and update this test if/when the GitLab API/documentation is fixed
assertTrue(hook.getRepositoryUpdateEvents());

assertTrue(hook.getEnableSslVerification());
} finally {
// Ensure we remove the hook we added even if we had failures
gitLabApi.getSystemHooksApi().deleteSystemHook(hook);
}

hook.withPushEvents(false)
.withTagPushEvents(true)
Expand All @@ -76,15 +84,23 @@ public void testAddSystemHook() throws GitLabApiException {
.withEnableSslVerification(false);

SystemHook updatedHook = gitLabApi.getSystemHooksApi().addSystemHook(TEST_HOOK_URL, TEST_SECRET_TOKEN, hook);
assertNotNull(updatedHook);
assertEquals(TEST_HOOK_URL, updatedHook.getUrl());
assertFalse(hook.getPushEvents());
assertTrue(hook.getTagPushEvents());
assertTrue(hook.getMergeRequestsEvents());
assertFalse(hook.getRepositoryUpdateEvents());
assertFalse(hook.getEnableSslVerification());

gitLabApi.getSystemHooksApi().deleteSystemHook(updatedHook);
try {
assertNotNull(updatedHook);
assertEquals(TEST_HOOK_URL, updatedHook.getUrl());
assertFalse(updatedHook.getPushEvents());
assertTrue(updatedHook.getTagPushEvents());
assertTrue(updatedHook.getMergeRequestsEvents());

// TODO: Attribute "repository_update_events" is not being honored by GitLab API as per issue
// https://gitlab.com/gitlab-org/gitlab/-/issues/335129
// Revisit and update this test if/when the GitLab API/documentation is fixed
assertTrue(updatedHook.getRepositoryUpdateEvents());

assertFalse(updatedHook.getEnableSslVerification());
} finally {
// Ensure we remove the hook we added even if we had failures
gitLabApi.getSystemHooksApi().deleteSystemHook(updatedHook);
}

}

Expand Down