Skip to content

Conversation

@tubbynl
Copy link
Contributor

@tubbynl tubbynl commented Sep 14, 2021

draft on adding support for filtering Packages in the Packages api
fixes #755

please feedback on how te test this and/or the way of method overloading :)

@tubbynl tubbynl changed the title add support for PackageFilter in PackagesApi #755 add support for PackageFilter in PackagesApi Sep 14, 2021
@tubbynl
Copy link
Contributor Author

tubbynl commented Sep 14, 2021

build is green; but the added integration test fails

  • it does work locally if i replace the setup in TestPackageApi
    @BeforeClass
    public static void setup() {
        //gitLabApi = baseTestSetup();
        gitLabApi = new GitLabApi("https://gitlab.com", "PERSONAL_ACCESS_TOKEN");
        //testProject = getTestProject();
        testProject = new Project().withId(PROJECT_ID);
    }

not really a works-on-my-machine; (also gitlab.com ;) ), but i think the test project does not have packages enabled?

@tubbynl
Copy link
Contributor Author

tubbynl commented Sep 16, 2021

Could you please do a review of this one @jabby ?

@jabby
Copy link
Collaborator

jabby commented Oct 18, 2021

@tubbynl I will take care of the failed tests.

@jabby jabby merged commit e90e8ec into gitlab4j:master Oct 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PackageFilter not (yet) implemented

2 participants