Skip to content

Conversation

@didacrarbones
Copy link

No description provided.

Copy link

@dren-dk dren-dk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a worthwhile improvement.

The method renames are needed to be more correct, but upgrading ought to be trivial.

@jabby
Copy link
Collaborator

jabby commented Mar 8, 2022

@dren-dk I agree with you. I will keep older methods for backward compatibility. Old methods will be flagged as Deprecated and I will finish the renaming as the current code does not compile (see deleteNoteAwardEmoji at the end of the file)

I think @didacrarbones don't push latest version of the patchset but I value the work done.

BTW @dren-dk thanks for the review on all PR. I appreciate a lot.

@jabby
Copy link
Collaborator

jabby commented Mar 8, 2022

PR replace by #812

@didacrarbones thansk for your work on this.

@jabby jabby closed this Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants