Feature: Replace auth token with supplier #786
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use case: oauth2 access limited time tokens which should be updated on regular basis. Supplier allows us to move refresh logic outside client. Use specified setter to set up supplier after gitlab api object creation.
dren-dk
approved these changes
Mar 3, 2022
dren-dk
left a comment
dren-dk
left a comment
There was a problem hiding this comment.
Very nice and minimal improvement with backward compatible API .
jabby
approved these changes
Mar 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use case: oauth2 access limited time tokens which should be updated on regular basis. Supplier allows us to move refresh logic outside client.
Use specified setter to set up supplier after gitlab api object creation.