Fixed MembershipSourceType enum, UserApi.getMemberships() and implemented KeysApi #796
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…turning all strings from Gitlab into null
… user, not just the first page of them
dren-dk
changed the title
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User Memberships could not be used due to the MembershipSourceType always being null in the Membership, because Gitlab returns "Namespace" and "Project" rather than "NAMESPACE" and "PROJECT". The fix is to introduce a name field on the enum to have a place to store that string and make it available to users and to uppercase the string before trying to parse it as an enum name.
Fixed the UserApi.getMemberships() method so it returns all the memberships and added a Pager based method too for lazy fetching.
Added the KeysApi needed to look up users by ssh key fingerprint.