Migrate totalSize on RegistryRepositoryTag to support fat images #843
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@jabby could we please get feedback on and ideally approval of this PR? It looks sane and low-risk to me. |
|
I also would like to see this fix released. |
Contributor
|
@jabby are you still maintaining this project or did someone else take over who we could contact about this PR? |
Collaborator
|
In fact I have no time since too many months. I'm sorry for that. I will work on this very soon. |
jabby
approved these changes
Dec 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #743 has been opened about this issue.
In this short PR I propose a quick solution to solve it.
It allows a RepositoryTag to be deserialised correctly by Jackson even though a "fat" (>~2GB) docker image is fetched.