Skip to content

Conversation

@marcelstoer
Copy link
Contributor

Fixes #880

Co-authored-by: Jérémie Bresson <dev@jmini.fr>
@jmini
Copy link
Collaborator

jmini commented Mar 6, 2023

IMO this change should update the corresponding test:
https://github.com/gitlab4j/gitlab4j-api/blob/master/src/test/resources/org/gitlab4j/api/merge-request.json

By adding a line like:

  "detailed_merge_status": "can_be_merged",

See doc: https://docs.gitlab.com/ee/api/merge_requests.html#response

Co-authored-by: Jérémie Bresson <dev@jmini.fr>
Copy link
Collaborator

@jmini jmini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@jmini jmini merged commit ea9042e into gitlab4j:master Mar 17, 2023
@marcelstoer marcelstoer deleted the fix/merge-status branch March 17, 2023 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Deprecation of the merge_status API field

2 participants