Remove unnesesary runtime charset search #897
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jabby
requested changes
Jan 19, 2023
Collaborator
jabby
left a comment
jabby
left a comment
There was a problem hiding this comment.
Thanks for your contribution. I will merge it when master will be against Java 17.
Collaborator
|
This change needs |
jmini
requested changes
Apr 11, 2023
Collaborator
jmini
left a comment
jmini
left a comment
There was a problem hiding this comment.
This PR is now OK against branch 6.x which is targeting Java 11.
Use StandardCharsets.UTF_8 instead of "UTF-8" string. This removes necessity to throw a checked exception.
jmini
approved these changes
Apr 13, 2023
Collaborator
jmini
left a comment
jmini
left a comment
There was a problem hiding this comment.
I have rebased this PR on top of 6.x (which uses Java 11)
jabby
approved these changes
Apr 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use StandardCharsets.UTF_8 (in java, since java 1.7), instead of "UTF-8" string. This removes necessity to throw a checked exception.