Remove three checked GitLabApiException #928
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was not chance of throwing checked exception GitLabApiException from given three methods. I have removed them to make user code using given methods easier to read.
jmini
approved these changes
Mar 20, 2023
Collaborator
jmini
left a comment
jmini
left a comment
There was a problem hiding this comment.
I don't know the reason why the checked exception were thrown here.
For me it is OK to remove them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was not chance of throwing checked exception GitLabApiException from given three methods. I have removed them to make user code using given methods easier to read.
PS: If throwing GitLabApiException is wanted effect, I can make 'page' method throw them, instead of other exceptions (unchecked, like 'NoSuchElementException').