Skip to content

Restore hooks PATH before calling ruby. #186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 18, 2014
Merged

Restore hooks PATH before calling ruby. #186

merged 1 commit into from
Nov 18, 2014

Conversation

cirosantilli
Copy link
Contributor

@cirosantilli cirosantilli mentioned this pull request Oct 18, 2014
Closed
5 tasks
@cirosantilli cirosantilli mentioned this pull request Oct 22, 2014
Closed
2 tasks
@Razer6
Copy link
Member

Razer6 commented Oct 30, 2014

@randx Can you take a look? This is a starting point to fix errors if users have multiple rubies on the computer. This issue is popping of regularly in the last week. /cc @dosire

@dzaporozhets
Copy link
Contributor

Can you please explain what kind of problem with multiple rubies we have and how it fixes it?

@Razer6
Copy link
Member

Razer6 commented Oct 30, 2014

@randx In https://github.com/gitlabhq/gitlabhq/issues/8045#issuecomment-59495603, @cirosantilli started to explain

@cirosantilli
Copy link
Contributor Author

@randx this exists solely for: gitlabhq/gitlabhq#8131, rationale is there.

@dzaporozhets
Copy link
Contributor

@cirosantilli can you please do next?

  • take a look if this code compatible with custom hook support? (Custom hooks #190)
  • make it mergeable
  • bump version to 2.3.0
  • add CHANGELOG item

@vsizov
Copy link
Contributor

vsizov commented Nov 17, 2014

looks good for me

@cirosantilli
Copy link
Contributor Author

Updated. I think it works with the custom hooks.

dzaporozhets added a commit that referenced this pull request Nov 18, 2014
@dzaporozhets
Merge pull request #186 from cirosantilli/restore-path
53fed51 
Restore hooks PATH before calling ruby.
@dzaporozhets dzaporozhets merged commit 53fed51 into gitlabhq:master Nov 18, 2014
@cirosantilli cirosantilli deleted the restore-path branch November 18, 2014 12:13
@zzjin
Copy link

zzjin commented Nov 19, 2014

right with lastest gitlab master install on same machine.

@bbodenmiller bbodenmiller mentioned this pull request Nov 20, 2014
Closed
@cirosantilli cirosantilli mentioned this pull request Feb 20, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@cirosantilli @Razer6 @dzaporozhets @vsizov @zzjin @mikeploeger