-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Closed
Labels
component: image-buildermeta: staleThis issue/PR is stale and will be closed soonThis issue/PR is stale and will be closed soonteam: workspaceIssue belongs to the Workspace teamIssue belongs to the Workspace team
Description
For a full explanation of the problem, see this comment in 10298
The image-builder-mk3 requires support for multiple pull secrets to maintain parity with the imagePullSecrets in Kubernetes's pod spec.
Suggested approach
- add in
pullSecretsas an array of strings (can removepullSecretin a future PR, but out of scope for this ticket) - usage of these
pullSecretsthen becomes "loop through the secrets, only failing when all have failed"
Metadata
Metadata
Assignees
Labels
component: image-buildermeta: staleThis issue/PR is stale and will be closed soonThis issue/PR is stale and will be closed soonteam: workspaceIssue belongs to the Workspace teamIssue belongs to the Workspace team