Skip to content

Conversation

@jeanp413
Copy link
Member

@jeanp413 jeanp413 commented Nov 27, 2023

Description

Summary generated by Copilot

🤖[deprecated] Generated by Copilot at c3de5f8

This pull request migrates the dashboard and the verification service to use the public API for managing blocked repositories and email domains, and adds the corresponding types and methods to the public API package. It also removes some unused files and adds comments to the SCM service.

Related Issue(s)

Fixes #

How to test

Documentation

Preview status

Gitpod was successfully deployed to your preview environment.

Build Options

Build
  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer
  • analytics=segment
  • with-dedicated-emulation
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • /werft preemptible
    Saves cost. Untick this only if you're really sure you need a non-preemtible machine.
  • with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh. If enabled, with-preview and with-large-vm will be enabled.
  • with-monitoring

/hold

@jeanp413 jeanp413 force-pushed the jp/optimistic-earwig branch from 5bd8e39 to b4e85a5 Compare November 28, 2023 16:03
@jeanp413 jeanp413 marked this pull request as ready for review November 28, 2023 16:03
@jeanp413 jeanp413 requested a review from a team as a code owner November 28, 2023 16:03
@mustard-mh
Copy link
Contributor

mustard-mh commented Nov 29, 2023

We need to update dashboard, default value is false if we did not switch the checkbox

image

@mustard-mh
Copy link
Contributor

Add blocked domain, then dashboard is broken.

image

@mustard-mh
Copy link
Contributor

I will take care of it before @jeanp413 started working on it, if I have time

@mustard-mh
Copy link
Contributor

mustard-mh commented Nov 29, 2023

Fixed and did tests in preview env. Would be great if you could do rebase to main (we moved papi related files from gitpod-protocol to public-api/typescript-common) @jeanp413

@jeanp413 jeanp413 force-pushed the jp/optimistic-earwig branch from 729f04e to 1dec1d2 Compare November 29, 2023 18:08
@roboquat roboquat merged commit a997229 into main Nov 29, 2023
@roboquat roboquat deleted the jp/optimistic-earwig branch November 29, 2023 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants