Skip to content

Conversation

@selfcontained
Copy link
Contributor

@selfcontained selfcontained commented Dec 5, 2023

Description

Adjust git provider host check to account for 302 redirects

Summary generated by Copilot

🤖[deprecated] Generated by Copilot at 57cf20a

Improve redirect handling in isHostReachable method of auth-provider-service.ts. This method is used to check the availability of auth providers and avoid errors when they are unreachable.

How to test

Documentation

Preview status

Gitpod was successfully deployed to your preview environment.

Build Options

Build
  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer
  • analytics=segment
  • with-dedicated-emulation
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • /werft preemptible
    Saves cost. Untick this only if you're really sure you need a non-preemtible machine.
  • with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh. If enabled, with-preview and with-large-vm will be enabled.
  • with-monitoring

/hold

Copy link
Member

@AlexTugarev AlexTugarev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First!

@selfcontained
Copy link
Contributor Author

/unhold

@roboquat roboquat merged commit ca02c26 into main Dec 5, 2023
@roboquat roboquat deleted the brad/git-provider-redirect-check branch December 5, 2023 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants