Define ListOrganizationPrebuilds
#19316
Conversation
There was a problem hiding this comment.
This is the only relevant file, unfortunately, all of the generated files felt like updating the year.
| rpc WatchPrebuild(WatchPrebuildRequest) returns (stream WatchPrebuildResponse) {} | ||
|
|
||
| // ListOrganizationPrebuilds lists all prebuilds of an organization | ||
| rpc ListOrganizationPrebuilds(ListOrganizationPrebuildsRequest) returns (ListOrganizationPrebuildsResponse) {} |
There was a problem hiding this comment.
Ideally we would enhance the ListPrebuilds call with a scope argument that can be organization level or configuration level
There was a problem hiding this comment.
@svenefftinge I agree it would be unfortunate if we have to introduce another method when ListPrebuilds sounds like it should cover both. I don't have an issue with merging the props, although some like workspace_id and git_ref I would like to get rid of for our global prebuild use cases (at least for now).
Best would most likely be to redo the ListPrebuilds method entirely so that it supports proper pagination and supports filters. I am not sure if it would be fine to break this one, but I assume it's fine since nobody is using it externally, so refactoring our Projects code should be enough.
Originally, I separated this into its own method because I thought the effort on backporting the changes onto ListPrebuilds is too high, but think that your point about using just one method for all listings makes sense.
If we do decide to go with only ListPrebuilds, I think a configurationId filter would fit in nicely as well (or are there any clear advantages of having a scope for this?). This would enable us to add a dropdown for the desired configuration to the global list in the future.
Description
Defines an API to list all prebuilds across all configurations in an organization.
The API will be helpful in the upcoming global prebuilds history page, powering the list of all prebuilds. Eventually, we would also like to have a filter param for searching by configuration name.
Related Issue(s)
Fixes EXP-1115
Documentation
Preview status
gitpod:summary
Build Options
Build
Run the build with werft instead of GHA
Run Leeway with
--dont-testPublish
Installer
Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
If enabled this will build
install/previewIf enabled this will create the environment on GCE infra
Saves cost. Untick this only if you're really sure you need a non-preemtible machine.
Valid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh. If enabled,with-previewandwith-large-vmwill be enabled./hold