Skip to content

Conversation

@Siddhant-K-code
Copy link
Member

@Siddhant-K-code Siddhant-K-code commented Jan 22, 2024

Description

This PR fixes the integration settings URL and improves the copy functionality in the GitI Integration Modal component. Aligned the Copy input component to the modal and performs code cleanup.

Related Issue(s)

Fixes EXP-1182

How to test

  • Open preview environment
  • Go to user settings
  • Go to Git providers and Click New Integration

Documentation

Preview status

Gitpod was successfully deployed to your preview environment.

Build Options

Build
  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer
  • analytics=segment
  • with-dedicated-emulation
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • /werft preemptible
    Saves cost. Untick this only if you're really sure you need a non-preemtible machine.
  • with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh. If enabled, with-preview and with-large-vm will be enabled.
  • with-monitoring

/hold

Copy link
Member

@filiptronicek filiptronicek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thx

@Siddhant-K-code
Copy link
Member Author

/unhold

@roboquat roboquat merged commit eb2c3de into main Jan 23, 2024
@roboquat roboquat deleted the siddhant/exp-1182-developer-settings-urls-are-broken-in-new-git-integration branch January 23, 2024 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants