Skip to content

Conversation

@mustard-mh
Copy link
Contributor

@mustard-mh mustard-mh commented Jan 22, 2025

Description

Related Issue(s)

Fixes CLC-891

How to test

  • Open a workspace with JetBrains IDE like IntelliJ on preview environment
  • Exec commands like gp open <file> -w and git rebase -i HEAD~2 should wait until user close the editor
  • Relevant code paths such as gp preview will not be affected, it should work as before

Documentation

Preview status

Gitpod was successfully deployed to your preview environment.

Build Options

Build
  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer
  • analytics=segment
  • with-dedicated-emulation
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • /werft preemptible
    Saves cost. Untick this only if you're really sure you need a non-preemtible machine.
  • with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh. If enabled, with-preview and with-large-vm will be enabled.
  • with-monitoring

/hold

@mustard-mh mustard-mh changed the title WIP: TRY IT OUT [JetBrains] wait for the files to be closed before returning Jan 22, 2025
@mustard-mh mustard-mh marked this pull request as ready for review January 22, 2025 21:20
@mustard-mh mustard-mh requested review from a team as code owners January 22, 2025 21:20
@mustard-mh mustard-mh changed the title [JetBrains] wait for the files to be closed before returning [JetBrains] wait for the file to be closed before returning Jan 22, 2025
Copy link
Contributor

@iQQBot iQQBot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image image

@roboquat roboquat merged commit deb3093 into main Jan 23, 2025
57 of 58 checks passed
@roboquat roboquat deleted the hw/fix-jb-cli branch January 23, 2025 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants