Only use buildContext when building packages #162
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkg/build.Build may be called with a BuildOptions that contains a pre-generated BuildContext; in this case the BuildOptions value is largely ignored during context setup and may not be complete. The buildContext struct will be authoritative in this context and must be be used instead of buildOptions. One way that this issue manifests is when running a leeway script with dependencies as `leeway run` generates a buildContext and passes that into leeway.Build; the rest of the buildOptions is empty. When using buildOptions the RemoteCache field will always be empty, even if the buildContext value has a RemoteCache defined. By only using buildContext instead of buildOptions we resolve this confusion on what data is authoritative.
Codecov Report
@@ Coverage Diff @@
## main #162 +/- ##
=====================================
Coverage 8.36% 8.36%
=====================================
Files 20 20
Lines 3406 3406
=====================================
Hits 285 285
Misses 3069 3069
Partials 52 52 |
easyCZ
approved these changes
Aug 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reopening #153 to fix script dependencies not being cached
Description
Related Issue(s)
Fixes #
How to test
Documentation
/hold