test: remove flaky TestS3Cache_VerificationOverhead
#265
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test was measuring sub-millisecond durations (~10-12µs) which are dominated by measurement noise, Go runtime scheduling variance, and test framework overhead. This resulted in: - Inconsistent results across runs - Negative overhead values (impossible in reality) - Flaky CI failures The test itself acknowledged these limitations in its comments and directed users to use benchmarks instead. The existing benchmark functions (BenchmarkS3Cache_DownloadBaseline and BenchmarkS3Cache_DownloadWithVerification) provide accurate and reliable performance measurements. Co-authored-by: Ona <no-reply@ona.com>
leodido
changed the title
TestS3Cache_VerificationOverhead
This helper function was only used by the removed TestS3Cache_VerificationOverhead test and is no longer needed. Co-authored-by: Ona <no-reply@ona.com>
leodido
force-pushed
the
remove-flaky-verification-overhead-test
branch
from
4088de5 to
a4e978c
Compare
leodido
requested review from
corneliusludmann,
csweichel,
geropl,
iQQBot and
kylos101
nandajavarma
approved these changes
Nov 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Removes the flaky
TestS3Cache_VerificationOverheadtest that was causing intermittent CI failures.Why
The test was measuring sub-millisecond durations (~10-12µs) which are dominated by:
This resulted in:
The test itself acknowledged these limitations in its comments and directed users to use benchmarks instead.
How
Removed the test function and its helper
measureDownloadTimePerf. The existing benchmark functions provide accurate and reliable performance measurements:BenchmarkS3Cache_DownloadBaselineBenchmarkS3Cache_DownloadWithVerificationPart of https://linear.app/ona-team/issue/CLC-2063/ensure-leeway-extracts-builder-id-from-oidc-token