fix(build): correct total count in build summary #274
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move total++ after cache check to ensure count matches categorized packages. Previously, total would include packages not in cache that were skipped, causing total != (builtLocally + downloaded + alreadyCached). Co-authored-by: Ona <no-reply@ona.com>
leodido
force-pushed
the
fix/build-summary-total-count
branch
from
93a188a to
150b8b9
Compare
The parameter name 'initialStatus' was misleading as it represents the package status after downloads complete but before local builds start, not the initial status before any operations. Renamed to 'statusAfterDownload' for clarity. Co-authored-by: Ona <no-reply@ona.com>
kylos101
approved these changes
Nov 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes an accounting bug in the build summary where
totalwould not match the sum of categorized packages.Problem
In
printBuildSummary, thetotalcounter was incremented for all packages inallpkg, but packages not in cache were skipped withcontinue. This caused:Fix
Move
total++to after the cache check, so we only count packages that are actually in the cache and being categorized.Impact
Related
Follow-up to #273 which was just merged.