Bytes for everyone!

Author: kevin-brown

gitdb/db/loose.py

@@ -16,10 +16,10 @@
 )
 
 from gitdb.stream import (
-        DecompressMemMapReader,
-        FDCompressedSha1Writer,
-        FDStream,
-        Sha1Writer
+    DecompressMemMapReader,
+    FDCompressedSha1Writer,
+    FDStream,
+    Sha1Writer
 )
 
 from gitdb.base import (

gitdb/stream.py

@@ -551,7 +551,7 @@ def __init__(self):
 
     def write(self, data):
         """:raise IOError: If not all bytes could be written
-        :return: lenght of incoming data"""
+        :return: length of incoming data"""
         self.sha1.update(data)
         return len(data)
 

gitdb/test/db/test_ref.py

@@ -24,7 +24,7 @@ def make_alt_file(self, alt_path, alt_list):
 
     @with_rw_directory
     def test_writing(self, path):
-        NULL_BIN_SHA = '\0'  * 20
+        NULL_BIN_SHA = '\0'.encode("ascii") * 20
 
         alt_path = os.path.join(path, 'alternates')
         rdb = ReferenceDB(alt_path)
@@ -35,7 +35,6 @@ def test_writing(self, path):
         # try empty, non-existing
         assert not rdb.has_object(NULL_BIN_SHA)
 
-
         # setup alternate file
         # add two, one is invalid
         own_repo_path = fixture_path('../../../.git/objects')       # use own repo

gitdb/test/test_stream.py

@@ -111,13 +111,13 @@ def test_decompress_reader(self):
 
     def test_sha_writer(self):
         writer = Sha1Writer()
-        assert 2 == writer.write("hi")
+        assert 2 == writer.write("hi".encode("ascii"))
         assert len(writer.sha(as_hex=1)) == 40
         assert len(writer.sha(as_hex=0)) == 20
 
         # make sure it does something ;)
         prev_sha = writer.sha()
-        writer.write("hi again")
+        writer.write("hi again".encode("ascii"))
         assert writer.sha() != prev_sha
 
     def test_compressed_writer(self):