Also support escape for dismissing commit error message

[Tillerino]

Is your feature request related to a problem? Please describe.
I love using pre-commit hooks and gitui nicely displays the output of the pre-commit hook when it fails:

(the stacked dialogs... so beautiful 🤩)

To close this error, I now have to press enter. Escape does not work. The first couple of times, I actually quit gitui because I could not figure out how to close the dialog. Enter just does not compute for me, especially since gitui is pretty consistent with escape closing the current dialog.

I eventually figured out enter, but that breaks my brain every time. After pressing enter, I am now back in the commit dialog:

I need to edit or stage stuff now, so I want to get rid of the commit dialog. What do I do? My monkey brain tells me: Close dialog again = repeat action = repeat key press. But I am in a text field. Pressing enter will just insert a line break. So for a couple of seconds, I just drool on my keyboard until eventually "close dialog = escape" echoes back to me from the future. Every time I feel like I was briefly unconscious.

Describe the solution you'd like
I want to close the commit error message dialog with escape. I think that would be consistent.

[extrawurst]

Good point. I cant recall why we used enter on these.. I am open for a PR to change that default but feel free to give it a try using the custom key bindings

[Tillerino]

Ah sorry, I didn't even know there are custom key bindings. Should have checked. But I can't find the binding for this one. I don't know what this is called, so I am just looking for enter. These are the ones I can see:

enter: GituiKeyEvent::new(KeyCode::Enter,  KeyModifiers::empty()),
select_tag: GituiKeyEvent::new(KeyCode::Enter,  KeyModifiers::empty()),
stage_unstage_item: GituiKeyEvent::new(KeyCode::Enter,  KeyModifiers::empty()),
newline: GituiKeyEvent::new(KeyCode::Enter,  KeyModifiers::empty()),

[wessamfathi]

I'd like to work on this as my first issue. If no one's working on it, feel free to assign it to me!

[wessamfathi]

Sent a pull request with a potential fix. This changes the default key to close the popup from Enter to Escape. If you want, I can modify it to close it with either, but I didn't feel that was the best behavior.

Let me know your feedback. I love gitui and this is my first pull request to an open-source project, so I'm doubly excited :)