Skip to content

fix warnings and deny deprecated #2753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 28, 2025
Merged

fix warnings and deny deprecated #2753

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a37a36e
fix gitoxide warning
extrawurst Oct 28, 2025
a2a6e89
do not allow deprecated fn
extrawurst Oct 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion asyncgit/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,8 @@ It wraps libraries like git2 and gix.
unused_must_use,
dead_code,
unstable_name_collisions,
unused_assignments
unused_assignments,
deprecated
)]
#![deny(clippy::all, clippy::perf, clippy::nursery, clippy::pedantic)]
#![deny(
Expand Down
2 changes: 1 addition & 1 deletion asyncgit/src/sync/logwalker.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ impl<'a> LogWalkerWithoutFilter<'a> {
// reason this is 2^14, so benchmarking might reveal that there’s better values.
repo.object_cache_size_if_unset(2_usize.pow(14));

let commit = repo.head()?.peel_to_commit_in_place()?;
let commit = repo.head()?.peel_to_commit()?;

let tips = [commit.id];

Expand Down
48 changes: 12 additions & 36 deletions asyncgit/src/sync/remotes/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -369,12 +369,8 @@ mod tests {
let (remote_dir, _remote) = repo_init().unwrap();
let remote_path = remote_dir.path().to_str().unwrap();
let (repo_dir, _repo) = repo_clone(remote_path).unwrap();
let repo_path: &RepoPath = &repo_dir
.into_path()
.as_os_str()
.to_str()
.unwrap()
.into();
let repo_path: &RepoPath =
&repo_dir.keep().as_os_str().to_str().unwrap().into();

let remotes = get_remotes(repo_path).unwrap();

Expand All @@ -388,12 +384,8 @@ mod tests {
let (remote_dir, _remote) = repo_init().unwrap();
let remote_path = remote_dir.path().to_str().unwrap();
let (repo_dir, _repo) = repo_clone(remote_path).unwrap();
let repo_path: &RepoPath = &repo_dir
.into_path()
.as_os_str()
.to_str()
.unwrap()
.into();
let repo_path: &RepoPath =
&repo_dir.keep().as_os_str().to_str().unwrap().into();

debug_cmd_print(
repo_path,
Expand All @@ -418,12 +410,8 @@ mod tests {
let (remote_dir, _remote) = repo_init().unwrap();
let remote_path = remote_dir.path().to_str().unwrap();
let (repo_dir, _repo) = repo_clone(remote_path).unwrap();
let repo_path: &RepoPath = &repo_dir
.into_path()
.as_os_str()
.to_str()
.unwrap()
.into();
let repo_path: &RepoPath =
&repo_dir.keep().as_os_str().to_str().unwrap().into();

debug_cmd_print(
repo_path,
Expand Down Expand Up @@ -454,12 +442,8 @@ mod tests {
let (remote_dir, _remote) = repo_init().unwrap();
let remote_path = remote_dir.path().to_str().unwrap();
let (repo_dir, _repo) = repo_clone(remote_path).unwrap();
let repo_path: &RepoPath = &repo_dir
.into_path()
.as_os_str()
.to_str()
.unwrap()
.into();
let repo_path: &RepoPath =
&repo_dir.keep().as_os_str().to_str().unwrap().into();

debug_cmd_print(
repo_path,
Expand Down Expand Up @@ -494,12 +478,8 @@ mod tests {
let (remote_dir, _remote) = repo_init().unwrap();
let remote_path = remote_dir.path().to_str().unwrap();
let (repo_dir, repo) = repo_clone(remote_path).unwrap();
let repo_path: &RepoPath = &repo_dir
.into_path()
.as_os_str()
.to_str()
.unwrap()
.into();
let repo_path: &RepoPath =
&repo_dir.keep().as_os_str().to_str().unwrap().into();

debug_cmd_print(
repo_path,
Expand Down Expand Up @@ -530,12 +510,8 @@ mod tests {
let (remote_dir, _remote) = repo_init().unwrap();
let remote_path = remote_dir.path().to_str().unwrap();
let (repo_dir, repo) = repo_clone(remote_path).unwrap();
let repo_path: &RepoPath = &repo_dir
.into_path()
.as_os_str()
.to_str()
.unwrap()
.into();
let repo_path: &RepoPath =
&repo_dir.keep().as_os_str().to_str().unwrap().into();

debug_cmd_print(
repo_path,
Expand Down
2 changes: 1 addition & 1 deletion asyncgit/src/sync/submodules.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,7 @@ mod tests {
s.add_finalize().unwrap();
}

let repo_p = RepoPath::Path(dir.into_path());
let repo_p = RepoPath::Path(dir.keep());
let subs = get_submodules(&repo_p).unwrap();

assert_eq!(subs.len(), 1);
Expand Down
Loading