again and again regression

[alexander-akait]

Input:

$var = $var + $var ?? '';

Input:

function gen() {
  yield 0;
  yield from from();
  yield 4;
}

I honestly can’t understand what the problem is, why you can not devote a little more time to tests and details, what is the problem of being more responsible for the project or asking for help (hi, i am here and can test branches before merge ✋ )?

Each update is pain and regressions 😞

I understand that we all have work here and a little time, but what is the problem to wait for the review and feedback before merge?

[czosel]

@evilebottnawi Just that I also understand the issue here: You're talking about pushing code directly to master which is breaking the CI build on master, right?
If so, then I'd also strongly encourage @ichiriac to always open a pull request for each change and only merge it when the CI passes. Also, it's always great if someone else who understands the codebase (e.g. @evilebottnawi) can look over it - that both helps to keep the quality up and also makes it easier for everyone else to keep track of the changes.

[alexander-akait]

@czosel yes, always wait green, do more tests and wait review, I am almost always available and respond very quickly

[alexander-akait]

Look regression here 09c943c, now parser works in php5 mode by default, before he works in php7 mode

[ichiriac]

Hi @evilebottnawi - the problem is quite simple :

little time = quick & dirty = commits on master && skip tests.

The real problem here is that I don't use or need the parser, I'm maintaining it just for helping users like you, but as I'm not dirrectly using it so I can't spend time on it as I have real life projects to finish (even on my spare time)

A solution for yourself could be to fork the project, making changes as you need, publish releases under new NPM package (php-parser2 for example)

As you keep the fork link, I may merge some things, and maybe you can also merge fixes from it - you could then make decisions and organize the project as you want. Anyway, time will come when then project may become either abandoned or maintained by some one else (or maybe replaced by another solution)

Here the problem is quite simple, this.php7 is undefined, and this.php73 is true :

It's quite obvious to debug, you're missing the method to find where it breaks, and be aware, using a tool like jison forget to debug it as it does not run an algorithm so it's a pain to find the stack, lexer state etc ...

The regression is on 09c943c, and it was failling silently, not a matter of tests, (BTW you're welcome to contribute, the issue is here : #49)

[ichiriac]

lets close this issue, I've added husky, I will not be able to commit with breaking test

[alexander-akait]

@ichiriac can you wait review for me before merge (and work using branches)? I will test branch and check code on something strange

[ichiriac]

@evilebottnawi don't put too much feelings, for me it's just an hobby, I don't expect anything from this project.

I've started to work alone, the master branch is the unstable/dev/testing even if it's an uggly & bad practice but it's good enough for me as I can push quick fixes without merging.

I think as you need to retain releases and handle yourself your changes, it's better to fork and try to keep it in sync if possible.

Also I think I'll wait some time before making the next release, so you'll have more room to make changes as you need.

Anyway, thanks for your contributions and I'll try to reply and help you as much I can.

[alexander-akait]

@ichiriac I had a discussion with WordPress developers and laravel, they wait php prettier, so it is the serious project for us, the guys also have money and maybe after stable release we will get funds, some of them we can to pay for your help in the work done, so I suggest that you take the project more seriously

[ichiriac]

I don't do this for money @evilebottnawi, and @czosel as owner I make my own (maybe bad but assumed) decisions depending on what I assume

Please go ahead, fork the project and use a new npm alias - it's really not a problem for me, and I will still try to help you as before