Skip to content

chore: refactor testing infrastructure #463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 6, 2020
Merged

chore: refactor testing infrastructure #463

merged 1 commit into from
Jan 6, 2020

Conversation

czosel
Copy link
Collaborator

@czosel czosel commented Jan 3, 2020

  • extract jest config into jest.config.js
  • run eslint using jest-runner-eslint
  • rename "lint" script to "fix" because it includes --fix
  • remove "cover" script, coverage can still be tested locally with
    COVERAGE=1 npm test
  • add eslint-plugin-jest
  • remove some redundant tests
  • refactor some tests using it.each

@czosel
Copy link
Collaborator Author

czosel commented Jan 3, 2020

I was glad I could use a vim macro to do this 😅

@czosel
Copy link
Collaborator Author

czosel commented Jan 3, 2020 •
edited
Loading

Up for discussion: running the tests pre-commit and pre-push seems a little bit too much. Shall we remove pre-push?

@coveralls
Copy link

coveralls commented Jan 3, 2020 •
edited
Loading

Coverage Status

Coverage remained the same at 96.157% when pulling 62f0ad5 on czosel:refactor-tests into 4e9d584 on glayzzle:master.

@czosel czosel mentioned this pull request Jan 3, 2020
Closed
@ichiriac
Copy link
Member

ichiriac commented Jan 5, 2020

@czosel agree with you, we can remove pre-push

ichiriac
ichiriac reviewed Jan 5, 2020
View reviewed changes
ichiriac
ichiriac reviewed Jan 5, 2020
View reviewed changes
ichiriac
ichiriac reviewed Jan 5, 2020
View reviewed changes
ichiriac
ichiriac reviewed Jan 5, 2020
View reviewed changes
ichiriac
ichiriac reviewed Jan 5, 2020
View reviewed changes
ichiriac
ichiriac requested changes Jan 5, 2020
View reviewed changes
Copy link
Member

@ichiriac ichiriac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure, but seems to have some problems with the coverage + need to fix automatically files on each commit

czosel
czosel commented Jan 5, 2020
View reviewed changes
@czosel
chore: refactor testing infrastructure
62f0ad5 
* extract jest config into jest.config.js
* run eslint using jest-runner-eslint
* rename "lint" script to "fix" because it includes --fix
* remove "cover" script, coverage can still be tested locally with
`COVERAGE=1 npm test`
* add eslint-plugin-jest
* remove some redundant tests
* refactor some tests using it.each
* remove pre-push test run
@czosel
Copy link
Collaborator Author

czosel commented Jan 5, 2020

@ichiriac The pre-push script is now removed 👍

@czosel
Copy link
Collaborator Author

czosel commented Jan 6, 2020

@ichiriac let me know if there are any more open questions - would be nice if we can get this merged before we get merge conflicts.

@ichiriac
Copy link
Member

ichiriac commented Jan 6, 2020

@czosel you're right, it's ok for me

@ichiriac ichiriac merged commit 4d8b8b7 into glayzzle:master Jan 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ichiriac ichiriac ichiriac requested changes

@alexander-akait alexander-akait Awaiting requested review from alexander-akait

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@czosel @coveralls @ichiriac