fix: remove trailing newline in flexible heredoc/nowdoc value

[czosel]

Fixes #468

[coveralls]

Coverage decreased (-0.02%) to 96.142% when pulling 6e372ba on czosel:fix-heredoc-trailing-newline into c4d95d8 on glayzzle:master.

[ichiriac]

Hi @czosel, problem comes from here : https://github.com/glayzzle/php-parser/blob/master/src/parser/scalar.js#L227

In this function I remove the last line break, but here the last char is the indentation, so you should before checking add an extra check on indentation, remove the trailing indentation, and then keep the strip of last line break.

[czosel]

Thanks for the pointer @ichiriac! I added a fix for nowdoc, but heredoc now I still have to figure out heredoc. Do you have another pointer? 😉

Update: Tests in prettier are passing now, because we're printing heredoc differently using raw instead of value - but we should fix heredoc here as well for consistency.

[ichiriac]

Not sure, but from reading the code it may be handled here : https://github.com/glayzzle/php-parser/blob/master/src/parser/scalar.js#L329

From case this.tok.T_START_HEREDOC: ->
if (this.lexer.curCondition === "ST_NOWDOC") {
} else {
--> return this.read_encapsed_string(this.tok.T_END_HEREDOC);
enter into a loop :
while (this.token !== expect && this.token !== this.EOF) {
      value.push(this.read_encapsed_string_item(true));
    }
and then using if (this.token === this.tok.T_ENCAPSED_AND_WHITESPACE) 

The problem here is that you may also have tokens T_ENCAPSED_AND_WHITESPACE at the start;, middle, and at the end ... so you should include the fix here : https://github.com/glayzzle/php-parser/blob/master/src/parser/scalar.js#L435

By testing if the last node kind is a string and something like this :

if (value.length > 0 && value[value.length -1].kind === 'string') {
 const node = value[value.length -1];
 if ( this.lexer.heredoc_label.indentation > 0) {
     node.value = node.value.substring(0, node.value.length - this.lexer.heredoc_label.indentation;
 }
 // because it was never handled before
 const lastCh = ... 
}

[czosel]

Thanks again for the pointers @ichiriac - I made the changes. I didn't need to remove the indentation for heredoc, because that's already done in remeve_heredoc_leading_whitespace_chars.

[ichiriac]

perfect 👍 ready to merge 💯