chore: rename base64 FFI functions #866
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xikaos
force-pushed
the
chore/base-ffi-naming-conventions
branch
from
9add60b to
edde488
Compare
xikaos
changed the title
|
Gleamland has spoken:
Unmarking this PR as draft and then this might be almost close to mergeable? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
#865
Summary
Replace
bit_arrayexisting base64 FFI function names following the convention `baseXX_operation() that already existed in base16 FFI function names.base64_encode()Erlang:
bit_array_base64_encode()->base64_encode().JS:
encode64()->base64_encode()decode64()-bit_arrayinternal functionErlang:
base_decode64->base64_decode()JS:
decode64()->base64_decode()