Skip to content

fix race condition on Close #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 4, 2020
Merged

fix race condition on Close #2

merged 1 commit into from
Sep 4, 2020

Conversation

@rafaeleyng
Copy link
Contributor

@rafaeleyng rafaeleyng commented Sep 4, 2020

If the flush took long enough, the select in consume could process first the signal originated from close(buffer.dataCh)(inside Close) than it would process the signal originated from close(buffer.closeCh)

@rafaeleyng
fix a race condition that could cause the dataCh receive data before …
8ca7384 
…the closeCh received the signal to end the consume loop
@mbenford mbenford merged commit bfb9996 into master Sep 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rafaeleyng @mbenford