Added details to the "ioz.cfg" file definitons.#174
Added details to the "ioz.cfg" file definitons.#174prashanthpai merged 2 commits intogluster:masterfrom
Conversation
@amye . As suggested by @ShyamsundarR , I have made necessary changes to the details of "ioz.cfg" file in the documentation.
|
@ShyamsundarR do you think this is good to go? |
|
Good change, 1+ from me but hold for Shyam. |
| Gluster mountpoint on each test machine): | ||
| Gluster mountpoint on each test machine). Each record in the file is a thread in IOZone terminology. Since we have defined the number of threads to be 4 in the above example, we have four records(threads) for a single client. | ||
|
|
||
| g01 /mnt/glusterfs /usr/local/bin/iozone |
There was a problem hiding this comment.
(nit) Not introduced with this change, but to keep the example and the CLI at line 170 the same, could we change g01 here to my-ip-address. What would be better is to define what g01 is, so that it is different than my-ip-address (i.e a remote machine than the one from where iozone is being run).
IOW, change this to something like,
"As an example consider a client to have the IP address test-client-ip, the ioz.cfg would hence contain,
test-client-ip /mnt/glusterfs/ ... (repeated 4 times)."
Sort of makes this better reading IMO.
There was a problem hiding this comment.
Yeah. Thank you, That makes it better to understand. I will make the changes soon.
ShyamsundarR
left a comment
ShyamsundarR
left a comment
There was a problem hiding this comment.
Added a nit, that is not due to this commit, but in the region changed. Would be nice to have that fixed as well.
|
I have fixed the suggested changes. Thanks. |
prashanthpai
left a comment
prashanthpai
left a comment
There was a problem hiding this comment.
LGTM 👍 I'll merge this once @ShyamsundarR gives his ack.
5 participants
@amye . As suggested by @ShyamsundarR , I have made necessary changes to the details of "ioz.cfg" file in the documentation. Kindly let me know, if a detailed explanation is required.