glusterdocs: Made some changes to the Quick Start#264
Merged
prashanthpai merged 3 commits intogluster:masterfrom Sep 14, 2017
nbalacha:QStart
Merged
glusterdocs: Made some changes to the Quick Start#264prashanthpai merged 3 commits intogluster:masterfrom nbalacha:QStart
prashanthpai merged 3 commits intogluster:masterfrom
nbalacha:QStart
Conversation
added 2 commits
September 13, 2017 21:15
- Added a missing step (configure firewall) without which the peer probe will fail. - Removed references to the New User guide as I couldn't find one in the docs. - Removed a redundant Quick Start Guide entry in the Install guide which basically just repeated the steps in the other one. - Renamed "Quick start Guide" to "Quick Start Guide" in mkdocs.yml. Signed-off-by: N Balachandran <nbalacha@redhat.com>
- Added a missing step (configure firewall) without which the peer probe will fail. - Removed references to the New User guide as I couldn't find one in the docs. - Removed a redundant Quick Start Guide entry in the Install guide which basically just repeated the steps in the other one. - Renamed "Quick start Guide" to "Quick Start Guide" in mkdocs.yml. - Changed the links in the Install section to point to the other Quick Start guide Signed-off-by: N Balachandran <nbalacha@redhat.com>
nigelbabu
reviewed
Sep 14, 2017
Contributor
nigelbabu
left a comment
nigelbabu
left a comment
There was a problem hiding this comment.
This looks good. Given we've removed the duplicate Quick start guide, can we remove the file entirely as well?
| found in the new user guide, below). We also do not explain the steps in | ||
| detail here, this guide is just to help you get it up and running as | ||
| soon as possible. After you deploy GlusterFS by following these steps, | ||
| using Fedora 22 (or later) virtual machines. |
Contributor
There was a problem hiding this comment.
I think it's time we switched this to CentOS 7 instead. Fedora will go out of date every 6 months. At the least, let's bump this up to F26.
Author
There was a problem hiding this comment.
I will update this to Fedora 26 for now. The Centos changes will be done as part of the larger doc revamp.
prashanthpai
requested changes
Sep 14, 2017
mkdocs.yml
Outdated
| - Overview: Install-Guide/Overview.md | ||
| - Common Criteria: Install-Guide/Common_criteria.md | ||
| - Quick start to Install: Install-Guide/Quick_start.md | ||
| # - Quick start to Install: Install-Guide/Quick_start.md |
Contributor
There was a problem hiding this comment.
Please remove this entry and also the Install-Guide/Quick_start.md file which will not be built.
Signed-off-by: N Balachandran <nbalacha@redhat.com>
prashanthpai
approved these changes
Sep 14, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
which the peer probe will fail.
find one in the docs.
the Install guide which just repeated the steps
in the other one.
mkdocs.yml.
Signed-off-by: N Balachandran nbalacha@redhat.com