[QOL] Remove obsolete jQuery code and extend keyboard shortcuts#733
Merged
Shwetha-Acharya merged 2 commits intogluster:mainfrom Jun 20, 2022
Merged
[QOL] Remove obsolete jQuery code and extend keyboard shortcuts#733Shwetha-Acharya merged 2 commits intogluster:mainfrom
Shwetha-Acharya merged 2 commits intogluster:mainfrom
Conversation
This patch also removes the obsolete fix-docs.js. That file depends of jQuery and we no longer use that. That file was also the cause of the console errors on current docs site. After this patch, users will be able to press C or Y(ank) to copy current address along with anchors to the clipboard. This feature is just an extension of multiple exisiting shortcuts like F/P/N. Another patch is in the works which would update current address so that current anchor is in the addressbar. That would make this patch more useful as you will be able to copy the adress of the location that you are currently reading in the doc and resume later or maybe share to someone. Cool, right? Signed-off-by: black-dragon74 <niryadav@redhat.com>
Member
Author
black-dragon74
changed the title
black-dragon74
added a commit
to black-dragon74/glusterdocs
that referenced
this pull request
Jun 16, 2022
This patch makes gluster#733 more usable and it updates the address of the current URL to the current anchor that you are reading at. Like, mysite/mychapter#mysectiom, using which, sharing the links will lead to the same place on the page that the user 1 was reading at. Signed-off-by: black-dragon74 <niryadav@redhat.com>
Shwetha-Acharya
approved these changes
Jun 20, 2022
Shwetha-Acharya
pushed a commit
that referenced
this pull request
Jun 20, 2022
This patch makes #733 more usable and it updates the address of the current URL to the current anchor that you are reading at. Like, mysite/mychapter#mysectiom, using which, sharing the links will lead to the same place on the page that the user 1 was reading at. Signed-off-by: black-dragon74 <niryadav@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch also removes the obsolete fix-docs.js. That
file depends of jQuery and we no longer use that. That file was also
the cause of the console errors on current docs site.
After this patch, users will be able to press C or Y(ank) to copy
current address along with anchors to the clipboard. This feature is just
an extension of multiple existing shortcuts like F/P/N.
Another patch is in the works which would update current address so that
current anchor is in the address-bar. That would make this patch more useful as
you will be able to copy the address of the location that you are currently reading
in the doc and resume later or maybe share to someone. Cool, right?
Signed-off-by: black-dragon74 niryadav@redhat.com