Skip to content

Conversation

@majk-p
Copy link
Contributor

@majk-p majk-p commented Sep 2, 2025

This PR applies the minimal dependency update required to move diffson to Scala Native 0.5.x. It's blocking gnieh/fs2-data#704 and some more libraries down stream

@ybasket ybasket requested a review from satabin September 2, 2025 07:21
@majk-p majk-p force-pushed the update/scala-native-0.5.x branch from 50981c7 to 334ddbb Compare September 2, 2025 10:07
@majk-p
Copy link
Contributor Author

majk-p commented Sep 2, 2025

The mima check fails because it's looking for _native0.5 versions of previous artifacts, while whole 4.x series was based on 0.4 native. I suppose the best solution is to release this change as diffson 5.0.0, with a relevant release note. WDYT @ybasket @satabin?

We could hack it the other way around by releasing 4.7.0 and telling mima not to check native version against previous artifacts, but I don't like it.

@kubukoz
Copy link

kubukoz commented Sep 5, 2025

We could hack it the other way around by releasing 4.7.0 and telling mima not to check native version against previous artifacts, but I don't like it.

fwiw I think this is the best solution, all the other libs will do the same thing when moving to sn0.5

@satabin
Copy link
Member

satabin commented Sep 8, 2025

Hi @majk-p and thanks for this contribution.

It looks good so far, and am still undecided with the strategy to adopt regarding MiMa. As mentioned by @kubukoz I think I will follow the way other libraries in the typelevel ecosystem do it for consistency.

I'd like also to see if we can wait for the Play! JSON release to avoid releasing with a milestone dependency.

@satabin satabin merged commit 8cf53fd into gnieh:main Sep 17, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants