Skip to content

Conversation

@jinoosss
Copy link
Member

Summary

This PR fixes an incorrect protobuf field tag number in the MsgCall message encoding. The args field was being encoded with tag number 42 instead of the correct tag number 50 that corresponds to field number 6 in the protobuf schema.

Problem

The generated TypeScript code had an incorrect wire format tag number for the MsgCall.args field:

  • Incorrect: writer.uint32(42).string(v!)
  • Correct: writer.uint32(50).string(v!)

This mismatch between the protobuf schema definition and the generated encoding logic could cause:

  • Serialization/deserialization errors
  • Network protocol incompatibility
  • Transaction broadcast failures when using MsgCall with arguments

Changes

  • Updated MsgCall.encode() method to use correct tag number 50 for the args field
  • This ensures proper serialization compatibility with the protobuf schema

Copy link
Member

@zivkovicmilos zivkovicmilos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch.

I'm sure this is leftover from the manual changes we are propagating out after #46.

#187 will fix these issues, hopefully

@zivkovicmilos zivkovicmilos merged commit 65cf21f into main Aug 27, 2025
2 checks passed
@zivkovicmilos zivkovicmilos deleted the fix/fix-a-msg-call-encode-proto branch August 27, 2025 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

3 participants