Skip to content

fix: Change UpdatePassword to take multiple addresses, roll back on error #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 17, 2024
Merged

fix: Change UpdatePassword to take multiple addresses, roll back on error #175

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
68b0b75
fix: Change UpdatePassword to take multiple addresses, roll back on e…
jefft0 Sep 11, 2024
e5bfbcf
fix: Change updatePassword to take a required array of Uint8Array
jefft0 Sep 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
452 changes: 315 additions & 137 deletions api/gen/csharp/Gnonativetypes.cs
View file
Open in desktop

Large diffs are not rendered by default.

25 changes: 15 additions & 10 deletions api/gen/csharp/RpcGrpc.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -709,8 +709,9 @@ public abstract partial class GnoNativeServiceBase
}

/// <summary>
/// Update the keybase to use the new password for the account in the keybase with the given address.
/// Before calling this, you must call SetPassword with the current password.
/// Update the keybase to use the new password for the accounts in the keybase with the given addresses.
/// Before calling this, you must call SetPassword with the current password for each account.
/// If there is an error, then roll back all accounts to the current password.
/// If there is no activated account with the given address, return [ErrCode](#land.gno.gnonative.v1.ErrCode).ErrNoActiveAccount.
/// </summary>
/// <param name="request">The request received from the client.</param>
Expand Down Expand Up @@ -1889,8 +1890,9 @@ protected GnoNativeServiceClient(ClientBaseConfiguration configuration) : base(c
return CallInvoker.AsyncUnaryCall(__Method_SetPassword, null, options, request);
}
/// <summary>
/// Update the keybase to use the new password for the account in the keybase with the given address.
/// Before calling this, you must call SetPassword with the current password.
/// Update the keybase to use the new password for the accounts in the keybase with the given addresses.
/// Before calling this, you must call SetPassword with the current password for each account.
/// If there is an error, then roll back all accounts to the current password.
/// If there is no activated account with the given address, return [ErrCode](#land.gno.gnonative.v1.ErrCode).ErrNoActiveAccount.
/// </summary>
/// <param name="request">The request to send to the server.</param>
Expand All @@ -1904,8 +1906,9 @@ protected GnoNativeServiceClient(ClientBaseConfiguration configuration) : base(c
return UpdatePassword(request, new grpc::CallOptions(headers, deadline, cancellationToken));
}
/// <summary>
/// Update the keybase to use the new password for the account in the keybase with the given address.
/// Before calling this, you must call SetPassword with the current password.
/// Update the keybase to use the new password for the accounts in the keybase with the given addresses.
/// Before calling this, you must call SetPassword with the current password for each account.
/// If there is an error, then roll back all accounts to the current password.
/// If there is no activated account with the given address, return [ErrCode](#land.gno.gnonative.v1.ErrCode).ErrNoActiveAccount.
/// </summary>
/// <param name="request">The request to send to the server.</param>
Expand All @@ -1917,8 +1920,9 @@ protected GnoNativeServiceClient(ClientBaseConfiguration configuration) : base(c
return CallInvoker.BlockingUnaryCall(__Method_UpdatePassword, null, options, request);
}
/// <summary>
/// Update the keybase to use the new password for the account in the keybase with the given address.
/// Before calling this, you must call SetPassword with the current password.
/// Update the keybase to use the new password for the accounts in the keybase with the given addresses.
/// Before calling this, you must call SetPassword with the current password for each account.
/// If there is an error, then roll back all accounts to the current password.
/// If there is no activated account with the given address, return [ErrCode](#land.gno.gnonative.v1.ErrCode).ErrNoActiveAccount.
/// </summary>
/// <param name="request">The request to send to the server.</param>
Expand All @@ -1932,8 +1936,9 @@ protected GnoNativeServiceClient(ClientBaseConfiguration configuration) : base(c
return UpdatePasswordAsync(request, new grpc::CallOptions(headers, deadline, cancellationToken));
}
/// <summary>
/// Update the keybase to use the new password for the account in the keybase with the given address.
/// Before calling this, you must call SetPassword with the current password.
/// Update the keybase to use the new password for the accounts in the keybase with the given addresses.
/// Before calling this, you must call SetPassword with the current password for each account.
/// If there is an error, then roll back all accounts to the current password.
/// If there is no activated account with the given address, return [ErrCode](#land.gno.gnonative.v1.ErrCode).ErrNoActiveAccount.
/// </summary>
/// <param name="request">The request to send to the server.</param>
Expand Down
30 changes: 27 additions & 3 deletions api/gen/es/gnonativetypes_pb.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,11 +240,11 @@ export declare class UpdatePasswordRequest extends Message<UpdatePasswordRequest
newPassword: string;

/**
* The address of the account to update the password
* The addresses of the account to update the password
*
* @generated from field: bytes address = 2;
* @generated from field: repeated bytes addresses = 2;
*/
address: Uint8Array;
addresses: Uint8Array[];

constructor(data?: PartialMessage<UpdatePasswordRequest>);

Expand Down Expand Up @@ -2055,3 +2055,27 @@ export declare class HelloStreamResponse extends Message<HelloStreamResponse> {
static equals(a: HelloStreamResponse | PlainMessage<HelloStreamResponse> | undefined, b: HelloStreamResponse | PlainMessage<HelloStreamResponse> | undefined): boolean;
}

/**
* @generated from message land.gno.gnonative.v1.GNONATIVETYPES_BytesList
*/
export declare class GNONATIVETYPES_BytesList extends Message<GNONATIVETYPES_BytesList> {
/**
* @generated from field: repeated bytes Value = 1;
*/
Value: Uint8Array[];

constructor(data?: PartialMessage<GNONATIVETYPES_BytesList>);

static readonly runtime: typeof proto3;
static readonly typeName = "land.gno.gnonative.v1.GNONATIVETYPES_BytesList";
static readonly fields: FieldList;

static fromBinary(bytes: Uint8Array, options?: Partial<BinaryReadOptions>): GNONATIVETYPES_BytesList;

static fromJson(jsonValue: JsonValue, options?: Partial<JsonReadOptions>): GNONATIVETYPES_BytesList;

static fromJsonString(jsonString: string, options?: Partial<JsonReadOptions>): GNONATIVETYPES_BytesList;

static equals(a: GNONATIVETYPES_BytesList | PlainMessage<GNONATIVETYPES_BytesList> | undefined, b: GNONATIVETYPES_BytesList | PlainMessage<GNONATIVETYPES_BytesList> | undefined): boolean;
}

12 changes: 11 additions & 1 deletion api/gen/es/gnonativetypes_pb.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ export const UpdatePasswordRequest = proto3.makeMessageType(
"land.gno.gnonative.v1.UpdatePasswordRequest",
() => [
{ no: 1, name: "new_password", kind: "scalar", T: 9 /* ScalarType.STRING */ },
{ no: 2, name: "address", kind: "scalar", T: 12 /* ScalarType.BYTES */ },
{ no: 2, name: "addresses", kind: "scalar", T: 12 /* ScalarType.BYTES */, repeated: true },
],
);

Expand Down Expand Up @@ -782,3 +782,13 @@ export const HelloStreamResponse = proto3.makeMessageType(
],
);

/**
* @generated from message land.gno.gnonative.v1.GNONATIVETYPES_BytesList
*/
export const GNONATIVETYPES_BytesList = proto3.makeMessageType(
"land.gno.gnonative.v1.GNONATIVETYPES_BytesList",
() => [
{ no: 1, name: "Value", kind: "scalar", T: 12 /* ScalarType.BYTES */, repeated: true },
],
);

5 changes: 3 additions & 2 deletions api/gen/es/rpc_connect.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,8 +214,9 @@ export declare const GnoNativeService: {
readonly kind: MethodKind.Unary,
},
/**
* Update the keybase to use the new password for the account in the keybase with the given address.
* Before calling this, you must call SetPassword with the current password.
* Update the keybase to use the new password for the accounts in the keybase with the given addresses.
* Before calling this, you must call SetPassword with the current password for each account.
* If there is an error, then roll back all accounts to the current password.
* If there is no activated account with the given address, return [ErrCode](#land.gno.gnonative.v1.ErrCode).ErrNoActiveAccount.
*
* @generated from rpc land.gno.gnonative.v1.GnoNativeService.UpdatePassword
Expand Down
5 changes: 3 additions & 2 deletions api/gen/es/rpc_connect.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,8 +214,9 @@ export const GnoNativeService = {
kind: MethodKind.Unary,
},
/**
* Update the keybase to use the new password for the account in the keybase with the given address.
* Before calling this, you must call SetPassword with the current password.
* Update the keybase to use the new password for the accounts in the keybase with the given addresses.
* Before calling this, you must call SetPassword with the current password for each account.
* If there is an error, then roll back all accounts to the current password.
* If there is no activated account with the given address, return [ErrCode](#land.gno.gnonative.v1.ErrCode).ErrNoActiveAccount.
*
* @generated from rpc land.gno.gnonative.v1.GnoNativeService.UpdatePassword
Expand Down
10 changes: 6 additions & 4 deletions api/gen/go/_goconnect/rpc.connect.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading