Skip to content

Conversation

@jefft0
Copy link
Contributor

@jefft0 jefft0 commented Jul 16, 2025

PR gnolang/gno#4281 is merged which adds MaxDeposit to MsgCall and MsgRun. So we need to add it to the gnonative gRPC API.

  • Update go.mod to the latest github.com/gnolang/gno
  • In gnonativetypes.go, add MaxDeposit to MsgCall and MsgRun
  • In gnonativetypes.go MsgRun, also change Send from string to []Coin to be consistent with MsgCall. This is not a breaking change because we don't have run in the Expo module API, so no code is using it right now
  • Run make regenerate
  • In api.go, add the helper convertCoins and use it to simplify convertCallRequest, convertSendRequest and convertRunRequest
  • In api.go, support MaxDeposit in convertCallRequest and convertRunRequest
  • In expo/src/api, add optional maxDeposit in call and makeCallTx

Signed-off-by: Jeff Thompson <jeff@thefirst.org>
@jefft0 jefft0 requested a review from D4ryl00 July 16, 2025 11:54
Copy link
Contributor

@D4ryl00 D4ryl00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jefft0 jefft0 merged commit 28ad53a into gnolang:main Jul 16, 2025
@github-actions
Copy link

🎉 This PR is included in version 4.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@jefft0 jefft0 deleted the feat/add-max-deposit branch July 17, 2025 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants