Skip to content

CI: Demote error to warning if sha256 checksum in .yaml is empty. #616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

CI: Demote error to warning if sha256 checksum in .yaml is empty. #616

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 12 additions & 5 deletions assets/ci/octave_ci.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,11 +191,18 @@ function pkg_install_sha256_check (pkg_version, test_dir)
urlwrite (pkg_version.url, pkg_file);
sha256_sum = hash ("sha256", fileread (pkg_file));
if (! strcmp (sha256_sum, pkg_version.sha256))
step_error (sprintf (["Package checksum error:\n", ...
"\n\tFile: %s", ...
"\n\tExpected: '%s'", ...
"\n\tBut got: '%s'\n"], pkg_file, pkg_version.sha256, sha256_sum));
exit (1); # Return test failed.
if (isempty (sha256_sum))
step_warning (sprintf (["No package checksum:\n", ...
"\n\tFile: %s", ...
"\n\tExpected: '%s'", ...
"\n\tBut sha256 was empty.\n"], pkg_file, pkg_version.sha256));
else
step_error (sprintf (["Package checksum error:\n", ...
"\n\tFile: %s", ...
"\n\tExpected: '%s'", ...
"\n\tBut got: '%s'\n"], pkg_file, pkg_version.sha256, sha256_sum));
exit (1); # Return test failed.
endif
else
disp (["sha256 checksum ok: '", sha256_sum, "'"]);
endif
Expand Down