This repository has been archived by the owner on Apr 12, 2019. It is now read-only.
Use io reader for GetFormatPatch #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How about naming the new function GetFormatPatchReader and keep the old signature ? |
|
@strk GetFormatPatch is unnecessary I think. |
|
It would be for consistency with GetPatch. Consistency in naming is important, IMHO, and you don't want to change API of GetPatch. |
|
but ok if you just want to rename to GetFormatPatchReader and not provide GetFormatPatch... |
lafriks
approved these changes
Jan 6, 2018
appleboy
approved these changes
Jan 7, 2018
|
Why did you not rename the method ? |
|
nevermind, fixed via io.Copy as suggested on IRC |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As title.