Skip to content

Backport of migration fixes (#2604) #2677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 9, 2017
Merged

Backport of migration fixes (#2604) #2677

merged 3 commits into from
Oct 9, 2017

Conversation

@daviian
Copy link
Member

@daviian daviian commented Oct 8, 2017

Backport of #2604

@lafriks lafriks added this to the 1.2.0 milestone Oct 8, 2017
@daviian
Copy link
Member Author

daviian commented Oct 8, 2017

Changed migrations in this PR are exactly the same as on master branch, except for markdown vs markup usage.

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 8, 2017
@lunny
Copy link
Member

lunny commented Oct 9, 2017

LGTM

@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Oct 9, 2017
daviian and others added 3 commits October 9, 2017 11:10
@daviian
Rewrite migrations to not depend on future code changes (go-gitea#2604)
33685d4 
* v38 migration used an outdated version of RepoUnit model (go-gitea#2602)

* change repoUnit model in migration

* fix v16 migration repo_unit table

* fix lint error

* move type definition inside function

* Fix migration from Gogs

* Refactor code

* add error check

* Additiomal fixes for migrations

* Add back nil check
@daviian
replace deprecated .Id with .ID
2fb3ef8 
Signed-off-by: David Schneiderbauer <dschneiderbauer@gmail.com>
@daviian
change string map to interface map
3559d28 
Signed-off-by: David Schneiderbauer <dschneiderbauer@gmail.com>
@daviian daviian force-pushed the backport/migrations branch from a44ffc6 to 3559d28 Compare October 9, 2017 09:11
@Morlinest
Copy link
Member

Morlinest commented Oct 9, 2017

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 9, 2017
@lafriks lafriks merged commit 74399f3 into go-gitea:release/v1.2 Oct 9, 2017
@daviian daviian deleted the backport/migrations branch October 9, 2017 13:09
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug

Projects

None yet

Milestone

1.2.0

Development

Successfully merging this pull request may close these issues.

5 participants

@daviian @lunny @Morlinest @tboerger @lafriks