Skip to content

Contribution heatmap improvements (#35876) #35880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 6, 2025
Merged

Contribution heatmap improvements (#35876) #35880

merged 1 commit into from
Nov 6, 2025
+34 −34

Conversation

@GiteaBot
Copy link
Collaborator

@GiteaBot GiteaBot commented Nov 6, 2025

Backport #35876 by @silverwind

  1. Set a fixed height on the element, preventing the content after the element from shifting on page load. This uses CSS container query length units as I saw no other way because of the non-linear scaling of the element.
  2. Move the "total-contributions" text into the existing vue slot, eliminating the need for absolute positioning.

@silverwind @wxiaoguang @GiteaBot
Contribution heatmap improvements (go-gitea#35876)
d8336b8 
1. Set a fixed height on the element, preventing the content after the
element from shifting on page load. This uses CSS [container query
length
units](https://developer.mozilla.org/en-US/docs/Web/CSS/CSS_containment/Container_queries#container_query_length_units)
as I saw no other way because of the non-linear scaling of the element.
2. Move the "total-contributions" text into the existing vue slot,
eliminating the need for absolute positioning.

---------

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
@GiteaBot GiteaBot added modifies/frontend modifies/templates This PR modifies the template files labels Nov 6, 2025
@GiteaBot GiteaBot added this to the 1.25.2 milestone Nov 6, 2025
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 6, 2025
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 6, 2025
@silverwind silverwind enabled auto-merge (squash) November 6, 2025 08:24
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 6, 2025
@silverwind silverwind added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Nov 6, 2025
@silverwind silverwind merged commit 5842cd2 into go-gitea:release/v1.25 Nov 6, 2025
26 checks passed
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Nov 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@silverwind silverwind silverwind approved these changes

@lafriks lafriks lafriks approved these changes

@delvh delvh Awaiting requested review from delvh

@wxiaoguang wxiaoguang Awaiting requested review from wxiaoguang

Assignees

@silverwind silverwind

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/frontend modifies/templates This PR modifies the template files

Projects

None yet

Milestone

1.25.2

Development

Successfully merging this pull request may close these issues.

3 participants

@GiteaBot @silverwind @lafriks