Move dropzone.js to npm/webpack #10645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silverwind
force-pushed
the
dropzone-npm
branch
2 times, most recently
from
c79df90 to
9a35e6f
Compare
guillep2k
approved these changes
Mar 7, 2020
GiteaBot
added
the
lgtm/need 1
|
I think this upgrade allows us to remove |
zeripath
approved these changes
Mar 7, 2020
GiteaBot
added
lgtm/done
|
We also need to look at making dropzone less difficult to configure - there are repeated user complaints about not being allowed to upload jars, zips etc. |
This is because we have this opinionated default: I think we should allow everything by default. It should not be our decision. Additionally, mime types are a bad abstraction because different browsers send different mime types for the same file extension. File extentions would be much better as they are guaranteed to be the same across browsers. |
|
Will do a few more refactors, don't land yet. |
Codecov Report
@@ Coverage Diff @@
## master #10645 +/- ##
==========================================
- Coverage 43.61% 43.6% -0.01%
==========================================
Files 588 588
Lines 82488 82485 -3
==========================================
- Hits 35975 35967 -8
- Misses 42052 42056 +4
- Partials 4461 4462 +1
Continue to review full report at Codecov.
|
- unvendor dropzone and upgrade it from 4.2.0 to 5.7.0 - make `csrf` available on window.config
|
Refactors removed, they require more work. Should be good to land. |
silverwind
added a commit
to silverwind/gitea
that referenced
this pull request
Jun 22, 2020
Dropzone 4.4 introduced a 30s XHR timeout that will kill any upload still in progress. This disable that timeout again. Ref: https://www.dropzonejs.com/#config-timeout Ref: go-gitea#10645 Ref: https://xhr.spec.whatwg.org/#the-timeout-attribute Fixes: go-gitea#12022 Fixes: go-gitea#11906
techknowlogick
pushed a commit
that referenced
this pull request
Jun 24, 2020
Dropzone 4.4 introduced a 30s XHR timeout that will kill any upload still in progress. This disable that timeout again. Ref: https://www.dropzonejs.com/#config-timeout Ref: #10645 Ref: https://xhr.spec.whatwg.org/#the-timeout-attribute Fixes: #12022 Fixes: #11906 Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
silverwind
added a commit
to silverwind/gitea
that referenced
this pull request
Jun 24, 2020
Dropzone 4.4 introduced a 30s XHR timeout that will kill any upload still in progress. This disable that timeout again. Ref: https://www.dropzonejs.com/#config-timeout Ref: go-gitea#10645 Ref: https://xhr.spec.whatwg.org/#the-timeout-attribute Fixes: go-gitea#12022 Fixes: go-gitea#11906 Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
techknowlogick
pushed a commit
that referenced
this pull request
Jun 24, 2020
Dropzone 4.4 introduced a 30s XHR timeout that will kill any upload still in progress. This disable that timeout again. Ref: https://www.dropzonejs.com/#config-timeout Ref: #10645 Ref: https://xhr.spec.whatwg.org/#the-timeout-attribute Fixes: #12022 Fixes: #11906 Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com> Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
ydelafollye
pushed a commit
to ydelafollye/gitea
that referenced
this pull request
Jul 31, 2020
Dropzone 4.4 introduced a 30s XHR timeout that will kill any upload still in progress. This disable that timeout again. Ref: https://www.dropzonejs.com/#config-timeout Ref: go-gitea#10645 Ref: https://xhr.spec.whatwg.org/#the-timeout-attribute Fixes: go-gitea#12022 Fixes: go-gitea#11906 Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
csrfavailable on window.configI noticed one bug already present on master while testing which is when 1 attachment is present, comment is edited and another one is added, it won't save correctly.
This PR should not introduce any regressions.