Monitor all git commands; move blame to git package and replace git as a variable #6864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lunny
added
the
type/refactoring
GiteaBot
added
the
lgtm/need 2
lunny
changed the title
Codecov Report
@@ Coverage Diff @@
## master #6864 +/- ##
==========================================
+ Coverage 41.23% 41.24% +<.01%
==========================================
Files 464 464
Lines 62832 62841 +9
==========================================
+ Hits 25909 25916 +7
- Misses 33531 33536 +5
+ Partials 3392 3389 -3
Continue to review full report at Codecov.
|
lunny
changed the title
|
Unit test for TestRepoIsEmpty fails in drone |
sapk
reviewed
May 7, 2019
| if err != nil { | ||
| if strings.Contains(stderr, "fatal: bad default revision 'HEAD'") { |
There was a problem hiding this comment.
This change seems to change how this function works. This will always error without setting the repo.IsEmpty previously to return. Is it intended because it fix an issue ? In place, of starting another cli command inside gitRepo.IsEmpty() couldn't we use a method IsEmptyRepoErr(err) parsing the error of OpenRepository ?
There was a problem hiding this comment.
I run make unit-test locally successfully but don't know why it failed on drone. I move these codes to git package so that external shouldn't know how it works.
lunny
force-pushed
the
lunny/uniform_git
branch
4 times, most recently
from
db5a963
to
e73f303
Compare
|
We should probably also set |
lunny
force-pushed
the
lunny/uniform_git
branch
2 times, most recently
from
19a9117
to
08a22c2
Compare
techknowlogick
approved these changes
Jun 18, 2019
GiteaBot
added
lgtm/need 1
sapk
approved these changes
Jun 26, 2019
GiteaBot
added
lgtm/done
jeffliu27
pushed a commit
to jeffliu27/gitea
that referenced
this pull request
Jul 18, 2019
…s a variable (go-gitea#6864) * monitor all git commands; move blame to git package and replace git as a variable * use git command but not other commands * fix build * move exec.Command to git.NewCommand * fix fmt * remove unrelated changes * remove unrelated changes * refactor IsEmpty and add tests * fix tests * fix tests * fix tests * fix tests * remove gitLogger * fix fmt * fix isEmpty * fix lint * fix tests
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR did some changes:
command.Runin git package so that all git processes will be monitored from admin panel. All these git processes haven't been monitored before."git"asgit.GitExecutablevariable. will replace Support git.PATH entry in app.ini #6772.IsEmptyforgit.Repositorywith tests.git.