brio-gen: cleanup files produced by tests on test success #951
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In tests of brio-gen, when a failure occurs (generated output changes) the new version is kept on disk. This is the existing behaviour. With this patch we remove the new version if there is no difference (test success). This allows to automatically remove those temporary files that are useful only for debugging a test failure.
Codecov Report
@@ Coverage Diff @@
## main #951 +/- ##
=======================================
Coverage 72.57% 72.57%
=======================================
Files 410 410
Lines 62067 62067
=======================================
Hits 45044 45044
Misses 14692 14692
Partials 2331 2331 Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In tests of brio-gen, when a failure occurs (generated output changes) the new version is kept on disk. This is the existing behaviour.
With this patch we remove the new version if there is no difference (test success). This allows to automatically remove those temporary files that are useful only for debugging a test failure.