chore(lint): code quality #64
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
❌ Your patch status has failed because the patch coverage (67.39%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## master #64 +/- ##
==========================================
+ Coverage 72.04% 74.81% +2.77%
==========================================
Files 2 2
Lines 279 274 -5
==========================================
+ Hits 201 205 +4
+ Misses 53 47 -6
+ Partials 25 22 -3 ☔ View full report in Codecov by Sentry. |
fredbi
force-pushed
the
chore/code-quality
branch
from
ac0c679 to
614b909
Compare
…sues * extended the set of enabled linters * improved readability of the set() method, which was too complex * added systematic checks on type assertion * removed impossible cases (type assertion _then_ same using reflect) * test: removed the use of global variables * test: improved the readability of tests * using t.Run() to label and hierarchize tests * using JSON test document as embedded asset Signed-off-by: Frederic BIDON <fredbi@yahoo.com>
fredbi
force-pushed
the
chore/code-quality
branch
from
614b909 to
562b254
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change type
Please select: 🆕 New feature or enhancement|🔧 Bug fix'|📃 Documentation update
Short description
Fixes
Full description
Checklist