Add BSON, SQL, and YAML support with conditional generation #16
Conversation
…eration Implement conditional code generation for database and serialization support: - Add -sql flag for database/sql driver.Valuer and sql.Scanner interfaces - Add -bson flag for MongoDB BSON marshaling/unmarshaling support - Add -yaml flag for gopkg.in/yaml.v3 support - All features are opt-in via flags to avoid forcing dependencies Key improvements: - BSON values stored as strings in MongoDB (fixes empty document issue) - Smart SQL NULL handling using zero values when available - Comprehensive integration tests with real MongoDB and SQLite - Runtime integration test that builds binary and verifies generated code - Test coverage for all marshal/unmarshal operations The generator now supports multiple database and serialization formats while maintaining zero runtime dependencies when features aren't used.
- Fix StatusValues and JobStatusValues references (now variables, not functions) - Add -sql flag to go:generate directives since SQL is no longer default - Update expected output in example tests to match actual enum order - These tests were broken since the August 11 major refactor that changed Values from function to variable
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
The test downloads dependencies and runs go mod tidy which times out in GitHub Actions at 60 seconds. This test is more suitable for local development where network access is faster.
Copilot review identified that negative values like -1 were being incorrectly parsed as 0. Added UnaryExpr handling in processExplicitValue to properly support negative number literals. Also fixed test expectation for SQL NULL handling with Priority enum where PriorityLow (0) is the zero value, not PriorityNone (-1).
There was a problem hiding this comment.
Pull Request Overview
This PR adds optional database and serialization support to the enum generator through conditional code generation, making features opt-in via command-line flags to avoid forcing unnecessary dependencies. The key change is making SQL support require the -sql flag (previously generated by default).
- Adds MongoDB BSON support (
-bsonflag) with proper string marshaling - Adds YAML support (
-yamlflag) for gopkg.in/yaml.v3 integration - Makes SQL support opt-in via
-sqlflag (breaking change)
Reviewed Changes
Copilot reviewed 20 out of 22 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| main.go | Adds new CLI flags for SQL, BSON, and YAML support |
| internal/generator/generator.go | Implements conditional generation logic and negative number support |
| internal/generator/enum.go.tmpl | Template with conditional blocks for optional features |
| internal/generator/integration_test.go | Comprehensive integration tests with real database containers |
| internal/generator/testdata/integration/ | Test data with generated enums for all features |
| README.md | Updated documentation explaining optional features and usage |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| case *ast.UnaryExpr: | ||
| // handle negative numbers like -1 | ||
| if e.Op == token.SUB { | ||
| if lit, ok := e.X.(*ast.BasicLit); ok { | ||
| if val, err := ConvertLiteralToInt(lit); err == nil { | ||
| state.lastExprType = exprTypePlain | ||
| state.lastValue = -val | ||
| state.iotaOp = nil | ||
| return -val | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
[nitpick] The negative number handling logic duplicates the error-ignoring pattern from ConvertLiteralToInt. Consider extracting this pattern or at least logging/handling the error from ConvertLiteralToInt to aid debugging when negative literals fail to parse.
Copilot uses AI. Check for mistakes.
| } | ||
| } | ||
|
|
||
| // These variables are used to prevent the compiler from reporting unused errors |
There was a problem hiding this comment.
[nitpick] The comment mentions 'unused errors' but should say 'unused constants' or 'unused variable errors' for clarity about what's being prevented.
| // These variables are used to prevent the compiler from reporting unused errors | |
| // These variables are used to prevent the compiler from reporting unused constant or unused variable errors |
Copilot uses AI. Check for mistakes.
- Added explanatory comment for error handling pattern in UnaryExpr case - Added comprehensive TestNegativeEnumValues with subtests - Improved test coverage to 99.6% - Addresses Copilot review feedback about duplicated error-ignoring pattern
1 participant
Summary
This PR adds optional database and serialization support to the enum generator through conditional code generation. Features are now opt-in via command-line flags to avoid forcing unnecessary dependencies.
Features Added
-bsonflag): GeneratesMarshalBSONValue/UnmarshalBSONValuemethods-sqlflag): Generatesdatabase/sql/driver.Valuerandsql.Scannerinterfaces-yamlflag): Generatesgopkg.in/yaml.v3Marshaler/Unmarshaler methodsBREAKING CHANGE
SQL support now requires the
-sqlflag (previously generated by default)Value()andScan()) were always generated-sqlflag is providedMigration Guide
If your code relies on SQL support, update your
go:generatedirectives:Rationale for Breaking Change
database/sqlimport when not using SQL databasesKey Improvements
Testing
Usage Examples
Documentation