Added checking for nil receiver on Validator methods #166
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I should be able to get this done later tonight |
Contributor
Author
|
Thanks! I have no problem with you implementing it in any other way, I just thought it was an easy way to add some clarity. |
deankarn
pushed a commit
that referenced
this pull request
Sep 2, 2015
Added checking for nil receiver on Validator methods
fairyhunter13
added a commit
to fairyhunter13/validator
that referenced
this pull request
Jul 12, 2020
Added checking for nil receiver on Validator methods
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
validator.Newis not called, the various validation methods can still be called since they are on the pointer, but it will panic with a slightly cryptic message. This still panics, but with a clear message that will hopefully save some other developers time in debugging.