Skip to content

Conversation

@manucorporat
Copy link

  • DRY. removed a lot of duplicated code in baked_in.go. Easier to read, maintain and debug
  • Faster StructValidationErrors.Error() by using bytes.Buffer
  • StructValidationErrors is allocated after some checks, it may save some cycles...

@manucorporat
Copy link
Author

If you want to merge it, please let me know, so I can fix the unit tests or restore the old error messages.

@deankarn
Copy link
Contributor

deankarn commented Apr 7, 2015

It looks great! I think I will merge it, I can update the unit test if it's too much trouble.

I do have one request though, if you could make the pull request against the v4-development branch instead of v4 directly; I would also like to update a few issues I found in my documentation before merging into v4.

Thanks!

deankarn pushed a commit that referenced this pull request Apr 8, 2015
@deankarn
Copy link
Contributor

deankarn commented Apr 8, 2015

changes merge!

@deankarn deankarn closed this Apr 8, 2015
CodeLingoBot pushed a commit to CodeLingoBot/go-playground-validator that referenced this pull request Apr 3, 2019
fairyhunter13 added a commit to fairyhunter13/validator that referenced this pull request Jul 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants